Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][bazel] Remove unneeded deps. #130696

Merged
merged 1 commit into from
Mar 11, 2025
Merged

[libc][bazel] Remove unneeded deps. #130696

merged 1 commit into from
Mar 11, 2025

Conversation

slackito
Copy link
Collaborator

The MPFRWrapper BUILD targets don't depend directly on gmp. MPFR itself does depend on gmp, but not the wrapper.

The MPFRWrapper BUILD targets don't depend directly on gmp. MPFR itself
does depend on gmp, but not the wrapper.
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Mar 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 11, 2025

@llvm/pr-subscribers-libc

Author: Jorge Gorbe Moya (slackito)

Changes

The MPFRWrapper BUILD targets don't depend directly on gmp. MPFR itself does depend on gmp, but not the wrapper.


Full diff: https://github.com/llvm/llvm-project/pull/130696.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel (-2)
diff --git a/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel
index 28922ba114740..79b7e146eb1ce 100644
--- a/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel
@@ -48,7 +48,6 @@ libc_test_library(
         "//libc:__support_macros_properties_types",
         "//libc/test/UnitTest:fp_test_helpers",
         "//libc/utils/MPFRWrapper:mpfr_impl",
-        "@gmp//:gmp_",
     ],
 )
 
@@ -82,6 +81,5 @@ libc_test_library(
         "//libc/test/UnitTest:LibcUnitTest",
         "//libc/test/UnitTest:fp_test_helpers",
         "//libc/utils/MPFRWrapper:mpfr_impl",
-        "@gmp//:gmp_",
     ],
 )

@vonosmas
Copy link
Contributor

LGTM, assuming Bazel build won't be throwing link errors due to -lgmp not passed in some build configurations.

@slackito
Copy link
Collaborator Author

LGTM, assuming Bazel build won't be throwing link errors due to -lgmp not passed in some build configurations.

I tried it locally and it worked. If it breaks someone we can revert.

@slackito slackito merged commit 5bf0486 into llvm:main Mar 11, 2025
12 checks passed
Bertik23 pushed a commit to Bertik23/llvm-project that referenced this pull request Mar 12, 2025
The MPFRWrapper BUILD targets don't depend directly on gmp. MPFR itself
does depend on gmp, but not the wrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants