[AstMatcher]templateArgumentCountIs support FunctionDecl
#130416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old `constructFrom` has hidden requirement which TypeMatcher must be used before ArgumentMatcher because there are bind inside. Inlining this function to make it more intuitive.
`hasTemplateArgument` and `templateArgumentCountIs` are always used together. It is more convenient to make then support `FunctionDecl`.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 8, 2025
|
@llvm/pr-subscribers-clang Author: Congcong Cai (HerrCai0907) Changes
Full diff: https://github.com/llvm/llvm-project/pull/130416.diff 1 Files Affected:
diff --git a/clang/include/clang/ASTMatchers/ASTMatchers.h b/clang/include/clang/ASTMatchers/ASTMatchers.h
index 0f7e3a8a01762..03d522072f6c1 100644
--- a/clang/include/clang/ASTMatchers/ASTMatchers.h
+++ b/clang/include/clang/ASTMatchers/ASTMatchers.h
@@ -1090,6 +1090,7 @@ AST_POLYMORPHIC_MATCHER_P2(
AST_POLYMORPHIC_MATCHER_P(
templateArgumentCountIs,
AST_POLYMORPHIC_SUPPORTED_TYPES(ClassTemplateSpecializationDecl,
+ VarTemplateSpecializationDecl, FunctionDecl,
TemplateSpecializationType),
unsigned, N) {
return internal::getTemplateSpecializationArgs(Node).size() == N;
|
PiotrZSL
requested changes
Mar 10, 2025
|
dump-ast-matchers has some bug. I will fix it after #130726 merging |
Base automatically changed from
users/ccc03-08-_clang-tidy_nfc_refactor_matcher_for_bugprone-optional-value-conversion
to
main
March 11, 2025 06:52
`hasTemplateArgument` and `templateArgumentCountIs` are always used together. It is more convenient to make then support `FunctionDecl`.
HerrCai0907
force-pushed
the
users/ccc03-08-_astmatcher_templateargumentcountis_support_functiondecl_
branch
from
97ea315 to
b28bd17
Compare
…tcher_templateargumentcountis_support_functiondecl_
…ateargumentcountis_support_functiondecl_' into users/ccc03-08-_astmatcher_templateargumentcountis_support_functiondecl_
| <tr><td colspan="4" class="doc" id="templateArgumentCountIs2"><pre>Matches if the number of template arguments equals N. | ||
|
|
||
| Given | ||
| template<typename T> struct C {}; |
There was a problem hiding this comment.
Shouldn't this example be for functionDecl, instead of classTemplateSpecializationDecl?
There was a problem hiding this comment.
This is auto-generated from the python script based on the comments on the matcher.
| Given | ||
| template<typename T> struct C {}; | ||
| C<int> c; | ||
| classTemplateSpecializationDecl(templateArgumentCountIs(1)) |
|
Adding @AaronBallman as owner for |
AaronBallman
approved these changes
Mar 11, 2025
| <tr><td colspan="4" class="doc" id="templateArgumentCountIs2"><pre>Matches if the number of template arguments equals N. | ||
|
|
||
| Given | ||
| template<typename T> struct C {}; |
There was a problem hiding this comment.
This is auto-generated from the python script based on the comments on the matcher.
| @@ -1090,6 +1090,7 @@ AST_POLYMORPHIC_MATCHER_P2( | |||
| AST_POLYMORPHIC_MATCHER_P( | |||
| templateArgumentCountIs, | |||
| AST_POLYMORPHIC_SUPPORTED_TYPES(ClassTemplateSpecializationDecl, | |||
| VarTemplateSpecializationDecl, FunctionDecl, | |||
There was a problem hiding this comment.
It'd probably be good to update the example code above. Also, can you add test coverage to clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp?
Merge activity
|
HerrCai0907
deleted the
users/ccc03-08-_astmatcher_templateargumentcountis_support_functiondecl_
branch
Bertik23
pushed a commit
to Bertik23/llvm-project
that referenced
this pull request
Mar 12, 2025
…0416) `hasTemplateArgument` and `templateArgumentCountIs` are always used together. It is more convenient to make then support `FunctionDecl`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasTemplateArgumentandtemplateArgumentCountIsare always used together. It is more convenient to make then supportFunctionDecl.