[NFC]Refactor static data splitter #125758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-xl
reviewed
Feb 4, 2025
| // Returns true iff any jump table is hot-cold categorized. | ||
| bool splitJumpTables(MachineFunction &MF); | ||
| void updateStats(bool ProfileAvailable, const MachineJumpTableInfo *MJTI); | ||
| void updateJumpTableStats(bool ProfileAvailable, |
| if (ProfileAvailable) | ||
| Changed |= partitionStaticDataWithProfiles(MF); | ||
|
|
||
| updateStats(ProfileAvailable, MF.getJumpTableInfo()); |
There was a problem hiding this comment.
can this be moved up before the partition? With that, an early return can be used when profile is not available.
There was a problem hiding this comment.
I revised the change to have updateStatsWithoutProfiles and updateStatsWithProfiles, and moved updateStatsWithoutProfiles up.
david-xl
approved these changes
Feb 4, 2025
snehasish
approved these changes
Feb 4, 2025
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
This is a split of llvm#125756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split of #125756