[Clang][TableGen] Use PointerType::get(Context) in MVE TableGen emitter (NFC)

[junlarsen]

Follow-up to #123569

I don't know if directly using the CodeGenModule here is the best solution. Let me know if there's something better to use.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Mats Jun Larsen (junlarsen)

Changes

Follow-up to #123569

I don't know if directly using the CodeGenModule here is the best solution. Let me know if there's something better to use.

---

Full diff: https://github.com/llvm/llvm-project/pull/124782.diff

1 Files Affected:

• (modified) clang/utils/TableGen/MveEmitter.cpp (+1-1)

diff --git a/clang/utils/TableGen/MveEmitter.cpp b/clang/utils/TableGen/MveEmitter.cpp
index 58a4d3c22ac366..334aedbb8592b5 100644
--- a/clang/utils/TableGen/MveEmitter.cpp
+++ b/clang/utils/TableGen/MveEmitter.cpp
@@ -210,7 +210,7 @@ class PointerType : public Type {
     return Name + " *";
   }
   std::string llvmName() const override {
-    return "llvm::PointerType::getUnqual(" + Pointee->llvmName() + ")";
+    return "llvm::PointerType::getUnqual(CGM.getLLVMContext())";
   }
   const Type *getPointeeType() const { return Pointee; }
 

[nikic]

LGTM

I don't know if directly using the CodeGenModule here is the best solution. Let me know if there's something better to use.

I think that's ok. The alternative would be Builder.getContext().

[nikic]

Well, I guess you could also use Builder.getPtrTy() for the whole thing...

[junlarsen]

I think I'll do that instead. Sounds a lot more reasonable in my opinion

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[junlarsen]

Test failures seem unrelated.