Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[msan] Generalize handleIntrinsicByApplyingToShadow by adding bitcasting #123474

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[msan] Generalize handleIntrinsicByApplyingToShadow by adding bitcasting #123474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d64d8b
[msan] Generalize handleIntrinsicByApplyingToShadow by adding bitcasting
thurstond Jan 18, 2025
f5d688c
Fix comment wording
thurstond Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4008,6 +4008,10 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
/// shadow[out] =
/// intrinsic(shadow[var1], shadow[var2], opType) | shadow[opType]
///
/// CAUTION: this assumes that the intrinsic will handle arbitrary
/// bit-patterns (for example, if the intrinsic accepts floats for
/// var1, we require that it doesn't care if inputs are NaNs).
///
/// For example, this can be applied to the Arm NEON vector table intrinsics
/// (tbl{1,2,3,4}).
///
Expand All @@ -4022,7 +4026,11 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
// Don't use getNumOperands() because it includes the callee
for (unsigned int i = 0; i < I.arg_size() - trailingVerbatimArgs; i++) {
Value *Shadow = getShadow(&I, i);
ShadowArgs.push_back(Shadow);

// Shadows are integer-ish types but some intrinsics require a
// different (e.g., floating-point) type.
ShadowArgs.push_back(
IRB.CreateBitCast(Shadow, I.getArgOperand(i)->getType()));
}

for (unsigned int i = I.arg_size() - trailingVerbatimArgs; i < I.arg_size();
Expand All @@ -4043,7 +4051,7 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
CombinedShadow = IRB.CreateOr(Shadow, CombinedShadow, "_msprop");
}

setShadow(&I, CombinedShadow);
setShadow(&I, IRB.CreateBitCast(CombinedShadow, getShadowTy(&I)));

setOriginForNaryOp(I);
}
Expand Down
Loading