Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libc/CMakeLists.txt: string sub-command REPLACE requires at least four arguments. #126358

Closed
sylvestre opened this issue Feb 8, 2025 · 1 comment · Fixed by #126359
Closed

libc/CMakeLists.txt: string sub-command REPLACE requires at least four arguments. #126358

sylvestre opened this issue Feb 8, 2025 · 1 comment · Fixed by #126359
Assignees
@sylvestre
Labels
build-problem libc
Milestone
LLVM 20.X Release

Comments

@sylvestre
Copy link
Collaborator

sylvestre commented Feb 8, 2025 •
edited
Loading

Caused by this change: #125831

-- Targeting AArch64
CMake Error at /build/source/libc/CMakeLists.txt:54 (string):
  string sub-command REPLACE requires at least four arguments.

Full log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-jammy-binaries/architecture=amd64,distribution=jammy,label=amd64/1939/console
@llvmbot
Copy link
Member

llvmbot commented Feb 8, 2025

@llvm/issue-subscribers-libc

Author: Sylvestre Ledru (sylvestre)

Caused by this change: https://github.com//issues/125831 
-- Targeting AArch64
CMake Error at /build/source/libc/CMakeLists.txt:54 (string):
  string sub-command REPLACE requires at least four arguments.

if(LLVM_VERSION_MAJOR)
string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX ${LLVM_VERSION_SUFFIX})
set(default_namespace "_llvm_libc${LLVM_VERSION_MAJOR}${LLVM_VERSION_MINOR}${LLVM_VERSION_PATCH}_${NS_LLVM_VERSION_SUFFIX}")
endif()

@sylvestre sylvestre mentioned this issue Feb 8, 2025
Merged
@nickdesaulniers nickdesaulniers added this to the LLVM 20.X Release milestone Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Feb 10, 2025
@tru tru moved this from Needs Triage to Needs Fix in LLVM Release Status Feb 11, 2025
sylvestre added a commit that referenced this issue Feb 13, 2025
@sylvestre @jhuber6
libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (#126359)
c81139f 
Closes: #126358

cc @samvangysegem

---------

Co-authored-by: Joseph Huber <[email protected]>
@github-project-automation github-project-automation bot moved this from Needs Fix to Done in LLVM Release Status Feb 13, 2025
joaosaffran pushed a commit to joaosaffran/llvm-project that referenced this issue Feb 14, 2025
@sylvestre @jhuber6
libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (llvm#126359
7a3f6fb 
)

Closes: llvm#126358

cc @samvangysegem

---------

Co-authored-by: Joseph Huber <[email protected]>
swift-ci pushed a commit to swiftlang/llvm-project that referenced this issue Feb 14, 2025
@sylvestre @tstellar
libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (llvm#126359
17dd52c 
)

Closes: llvm#126358

cc @samvangysegem

---------

Co-authored-by: Joseph Huber <[email protected]>
(cherry picked from commit c81139f)
sivan-shani pushed a commit to sivan-shani/llvm-project that referenced this issue Feb 24, 2025
@sylvestre @jhuber6 @sivan-shani
libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (llvm#126359
991ca6d 
)

Closes: llvm#126358

cc @samvangysegem

---------

Co-authored-by: Joseph Huber <[email protected]>
YutongZhuu pushed a commit to YutongZhuu/llvm-project that referenced this issue Mar 8, 2025
@sylvestre @jhuber6 @YutongZhuu
libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (llvm#126359
0033f65 
)

Closes: llvm#126358

cc @samvangysegem

---------

Co-authored-by: Joseph Huber <[email protected]>
YutongZhuu pushed a commit to YutongZhuu/llvm-project that referenced this issue Mar 8, 2025
@sylvestre @jhuber6 @YutongZhuu
libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined (llvm#126359
af85094 
)

Closes: llvm#126358

cc @samvangysegem

---------

Co-authored-by: Joseph Huber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylvestre sylvestre

Labels
build-problem libc
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 20.X Release
Development

Successfully merging a pull request may close this issue.

libc/cmake: don't fail if LLVM_VERSION_SUFFIX isn't defined sylvestre/llvm-project
3 participants
@sylvestre @nickdesaulniers @llvmbot