Got the 'maximal stuff' building properly

llvm · Mar 4, 2024 · d13cb6f · d13cb6f
1 parent 4ffb928
commit d13cb6f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -363,7 +363,7 @@ ifneq "$(OS)" "Darwin"
 
 	OBJCOPY ?= $(call replace_cc_with,objcopy)
 	ARCHIVER ?= $(call replace_cc_with,ar)
-	DWP ?= $(call reaplce_cc_with,dwp)
+	DWP ?= $(call replace_cc_with,dwp)
 	override AR = $(ARCHIVER)
 endif
 
@@ -572,15 +572,15 @@ else
 endif
 else
 ifeq "$(SPLIT_DEBUG_SYMBOLS)" "YES"
-	ifneq "$(KEEP_FULL_DEBUG_BINARY)" "YES"
+  ifneq "$(KEEP_FULL_DEBUG_BINARY)" "YES"
 	$(OBJCOPY) --only-keep-debug "$(EXE)" "$(DSYM)"
-	else
+  else
 	cp "$(EXE)" "$(DSYM)"
-	endif
+  endif
 	$(OBJCOPY) --strip-debug --add-gnu-debuglink="$(DSYM)" "$(EXE)" "$(EXE)"
 endif
 ifeq "$(MERGE_DWOS)" "YES"
-	$(DWP) -o "$(DWP_FILE)" $(DWOS)
+	$(DWP) -o "$(DWP_NAME)" $(DWOS)
 endif
 endif
 

diff --git a/lldb/test/API/debuginfod/Makefile b/lldb/test/API/debuginfod/Makefile
@@ -1,5 +1,5 @@
 C_SOURCES := main.c
-CFLAGS_EXTRAS := -std=c99
+LDFLAGS := -Wl,--build-id
 
 MAKE_DWO := YES
 SPLIT_DEBUG_SYMBOLS := YES

diff --git a/lldb/test/API/debuginfod/TestSampleTest.py → lldb/test/API/debuginfod/TestDebuginfod.py b/lldb/test/API/debuginfod/TestSampleTest.py → lldb/test/API/debuginfod/TestDebuginfod.py
@@ -1,5 +1,5 @@
 """
-Describe the purpose of the test class here.
+Test support for the DebugInfoD network symbol acquisition protocol.
 """
 
 
@@ -8,14 +8,14 @@
 from lldbsuite.test.lldbtest import *
 
 
-class RenameThisSampleTestTestCase(TestBase):
+class DebugInfodTests(TestBase):
     # If your test case doesn't stress debug info, then
     # set this to true.  That way it won't be run once for
     # each debug info format.
     NO_DEBUG_INFO_TESTCASE = True
 
-    def test_sample_rename_this(self):
-        """There can be many tests in a test case - describe this test here."""
+    def test_stuff(self):
+        """This should test stuff."""
         self.build()
         self.main_source_file = lldb.SBFileSpec("main.c")
         self.sample_test()
@@ -25,7 +25,8 @@ def setUp(self):
         TestBase.setUp(self)
         # Set up your test case here. If your test doesn't need any set up then
         # remove this method from your TestCase class.
-        # I need to setup the file-system-hosted Debuginfod server
+        # I need to setup the file-system-hosted Debuginfod server 'root'.
+        # The files it should host can be generated per-test
 
     def sample_test(self):
         """You might use the test implementation in several ways, say so here."""