Skip to content

Commit

Permalink
Revert "[libc++] Disable _LIBCPP_NODEBUG temporarily (#122393)"
Browse files Browse the repository at this point in the history
This reverts commit 24bf0e4.
  • Loading branch information
philnik777 authored Jan 17, 2025
1 parent e79bb87 commit 617f84e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 1 addition & 3 deletions libcxx/include/__config
Original file line number Diff line number Diff line change
Expand Up @@ -1166,9 +1166,7 @@ typedef __char32_t char32_t;
# define _LIBCPP_NOESCAPE
# endif

// FIXME: Expand this to [[__gnu__::__nodebug__]] again once the testcase reported in
// https://github.com/llvm/llvm-project/pull/118710 has been analyzed
# define _LIBCPP_NODEBUG
# define _LIBCPP_NODEBUG [[__gnu__::__nodebug__]]

# if __has_attribute(__standalone_debug__)
# define _LIBCPP_STANDALONE_DEBUG __attribute__((__standalone_debug__))
Expand Down
2 changes: 1 addition & 1 deletion libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class LibcxxTestModule : public clang::tidy::ClangTidyModule {
check_factories.registerCheck<libcpp::header_exportable_declarations>("libcpp-header-exportable-declarations");
check_factories.registerCheck<libcpp::hide_from_abi>("libcpp-hide-from-abi");
check_factories.registerCheck<libcpp::internal_ftm_use>("libcpp-internal-ftms");
// check_factories.registerCheck<libcpp::nodebug_on_aliases>("libcpp-nodebug-on-aliases");
check_factories.registerCheck<libcpp::nodebug_on_aliases>("libcpp-nodebug-on-aliases");
check_factories.registerCheck<libcpp::proper_version_checks>("libcpp-cpp-version-check");
check_factories.registerCheck<libcpp::robust_against_adl_check>("libcpp-robust-against-adl");
check_factories.registerCheck<libcpp::uglify_attributes>("libcpp-uglify-attributes");
Expand Down

0 comments on commit 617f84e

Please sign in to comment.