[CIR][Dialect] Add minimal definitions of unified address space offload_* cases
#738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our current focus is on the |
seven-mile
changed the title
offload_* casesoffload_* cases
jopperm
approved these changes
Jul 15, 2024
Comment on lines
715
to
718
| /// Convert CIRGen-processed LangAS to CIR AS storage value. | ||
| /// For offloading languages like CUDA/SYCL, the actual LangAS like generic | ||
| /// or private should be passed, rather than Default. | ||
| /// Such "actual LangAS" should be figured out in CIRGen instead. |
There was a problem hiding this comment.
Suggestion to make this comment a bit clearer:
Suggested change
| /// Convert CIRGen-processed LangAS to CIR AS storage value. | |
| /// For offloading languages like CUDA/SYCL, the actual LangAS like generic | |
| /// or private should be passed, rather than Default. | |
| /// Such "actual LangAS" should be figured out in CIRGen instead. | |
| /// Convert a clang LangAS to its corresponding CIR AS storage value. This | |
| /// helper does not perform any language-specific mappings (e.g. determining | |
| /// the default AS for offloading languages), so these must be handled in | |
| /// the caller. |
Co-authored-by: Julian Oppermann <[email protected]>
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…oad_*` cases (llvm#738) This PR adds definitions of unified address space cases `offload_*` discussed in [this RFC thread](https://discourse.llvm.org/t/rfc-clangir-unified-address-space-design-in-clangir/79728). It also refactors the `getValueFromLangAS` method in tablegen to a hand-written method, because it should be a non-trivial map for unified AS. --------- Co-authored-by: Julian Oppermann <[email protected]>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…oad_*` cases (llvm#738) This PR adds definitions of unified address space cases `offload_*` discussed in [this RFC thread](https://discourse.llvm.org/t/rfc-clangir-unified-address-space-design-in-clangir/79728). It also refactors the `getValueFromLangAS` method in tablegen to a hand-written method, because it should be a non-trivial map for unified AS. --------- Co-authored-by: Julian Oppermann <[email protected]>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…oad_*` cases (llvm#738) This PR adds definitions of unified address space cases `offload_*` discussed in [this RFC thread](https://discourse.llvm.org/t/rfc-clangir-unified-address-space-design-in-clangir/79728). It also refactors the `getValueFromLangAS` method in tablegen to a hand-written method, because it should be a non-trivial map for unified AS. --------- Co-authored-by: Julian Oppermann <[email protected]>
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…oad_*` cases (llvm#738) This PR adds definitions of unified address space cases `offload_*` discussed in [this RFC thread](https://discourse.llvm.org/t/rfc-clangir-unified-address-space-design-in-clangir/79728). It also refactors the `getValueFromLangAS` method in tablegen to a hand-written method, because it should be a non-trivial map for unified AS. --------- Co-authored-by: Julian Oppermann <[email protected]>
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
…oad_*` cases (#738) This PR adds definitions of unified address space cases `offload_*` discussed in [this RFC thread](https://discourse.llvm.org/t/rfc-clangir-unified-address-space-design-in-clangir/79728). It also refactors the `getValueFromLangAS` method in tablegen to a hand-written method, because it should be a non-trivial map for unified AS. --------- Co-authored-by: Julian Oppermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds definitions of unified address space cases
offload_*discussed in this RFC thread.It also refactors the
getValueFromLangASmethod in tablegen to a hand-written method, because it should be a non-trivial map for unified AS.