[CIR][Asm] Remove duplicated lambda & coroutine attributes #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not print in cir.func definition the 'attr { ... }' with coroutine
or lambda attributes since they are already printed before the
function name. Otherwise redundancy breaks a future parsing.
Sort the attributes to be skipped so it is more obvious to see the
list of attributes.
Improve the tests to check they are no spurious attributes anymore.
|
I have also an |
That'd be cool, I'm not sure how to do that though, would love suggestions! |
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
Do not print in cir.func definition the 'attr { ... }' with coroutine or
lambda attributes since they are already printed before the function
name. Otherwise redundancy breaks a future parsing. Sort the attributes
to be skipped so it is more obvious to see the list of attributes.
Improve the tests to check there are no spurious attributes anymore.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Do not print in cir.func definition the 'attr { ... }' with coroutine or
lambda attributes since they are already printed before the function
name. Otherwise redundancy breaks a future parsing. Sort the attributes
to be skipped so it is more obvious to see the list of attributes.
Improve the tests to check there are no spurious attributes anymore.
keryell
added a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Do not print in cir.func definition the 'attr { ... }' with coroutine or
lambda attributes since they are already printed before the function
name. Otherwise redundancy breaks a future parsing. Sort the attributes
to be skipped so it is more obvious to see the list of attributes.
Improve the tests to check there are no spurious attributes anymore.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Do not print in cir.func definition the 'attr { ... }' with coroutine or
lambda attributes since they are already printed before the function
name. Otherwise redundancy breaks a future parsing. Sort the attributes
to be skipped so it is more obvious to see the list of attributes.
Improve the tests to check there are no spurious attributes anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not print in cir.func definition the 'attr { ... }' with coroutine or lambda attributes since they are already printed before the function name. Otherwise redundancy breaks a future parsing. Sort the attributes to be skipped so it is more obvious to see the list of attributes.
Improve the tests to check there are no spurious attributes anymore.