[CIR[CIRGen][NFC] Refactor build switch op #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
changed the title
bcardosolopes
requested changes
Apr 19, 2024
clang/lib/CIR/CodeGen/CIRGenStmt.cpp
Outdated
| assert(defaultStmt && "expected default stmt"); | ||
| res = buildDefaultStmt(*defaultStmt, condV.getType(), caseAttrs, | ||
| os); | ||
| SmallVector<mlir::Attribute, 4> caseAttrs; |
There was a problem hiding this comment.
This block of logic here can be abstracted into its own helper function: all it does it building CaseOpKindAttr.
There was a problem hiding this comment.
Added switchCondType in LexScope and moved these logic into helper function, thanks.
There was a problem hiding this comment.
Passing params to functions is totally fine, things shouldn't be added to LexScope unless strictly needed. And if it's needed to fix a bug or support nested switches, should be added when time for that PR comes. Please don't add switchCondType into LexScope.
There was a problem hiding this comment.
Sure, reverted the related changes, leave it to the future pr.
wenpen
force-pushed
the
refactor_build_switch_op
branch
from
65c8be7 to
c495036
Compare
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from #528.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from #528.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from #528.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from llvm#528.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from llvm#528.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from llvm#528.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Make logic cleaner and more extensible. Separate collecting `SwitchStmt` information and building op logic into different functions. Add more UT to cover nested switch, which also worked before this pr. This pr is split from #528.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make logic cleaner and more extensible.
Separate collecting
SwitchStmtinformation and building op logic into different functions.Add more UT to cover nested switch, which also worked before this pr.
This pr is split from #528.