[CIR][CodeGen] Flattening for ScopeOp and LoopOpInterface #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitoleg
force-pushed
the
scope-n-loop-flattening
branch
from
12f174c to
aefdb23
Compare
|
@bcardosolopes rebased! |
Closed
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR is the next step towards goto support and adds flattening for
`ScopeOp` and `LoopOpInterface`.
Looks like I can't separate this operations and create two PRs, since
some errors occur if I do so, e.g. `reference to block defined in
another region`. Seems we need to flatten both operations in the same
time. Given it's a copy-pasta, I think there is no need to try to make
several PRs.
I added several tests - just copied them from the lowering part just to
demonstrate how it looks like.
Note, that changes in `dot.cir` caused by `BrCondOp` updates in the
previous PR, when we removed the following casts:
```
%20 = llvm.zext %19 : i1 to i8
%21 = llvm.trunc %20 : i8 to i1
llvm.cond_br %21 ...
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next step towards goto support and adds flattening for
ScopeOpandLoopOpInterface.Looks like I can't separate this operations and create two PRs, since some errors occur if I do so, e.g.
reference to block defined in another region. Seems we need to flatten both operations in the same time. Given it's a copy-pasta, I think there is no need to try to make several PRs.I added several tests - just copied them from the lowering part just to demonstrate how it looks like.
Note, that changes in
dot.circaused byBrCondOpupdates in the previous PR, when we removed the following casts: