[CIR][NFC] Add unimplemented feature guard for dialect code #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The present UnimplementedFeature class is made for the CodeGen submodule. This patch adds a new CIRDialectUnimplementedFeature class that provides unimplemented feature guards for CIR dialect code under clang/lib/CIR/Dialect/IR.
|
|
||
| namespace cir { | ||
|
|
||
| struct CIRDialectUnimplementedFeature { |
There was a problem hiding this comment.
Rename CIRDialectUnimplementedFeature -> MissingFeatures. CIRGen is a bit different because we unimplemented tracks things relative to traditional codegen. Here we don't have a dialect to compare against, so "missing" sounds more accurate.
There was a problem hiding this comment.
Also rename the file to "MissingFeatures.h"
| @@ -408,20 +412,23 @@ llvm::TypeSize | |||
| DataMemberType::getTypeSizeInBits(const ::mlir::DataLayout &dataLayout, | |||
| ::mlir::DataLayoutEntryListRef params) const { | |||
| // FIXME: consider size differences under different ABIs | |||
| assert(!CIRDialectUnimplementedFeature::cxxABI()); | |||
There was a problem hiding this comment.
Using the name suggested in the next comment, this becomes assert(!cir::MissingFeature::cxxABI()).
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
As discussed in pull #401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
As discussed in pull llvm#401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
As discussed in pull #401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
As discussed in pull #401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
As discussed in pull llvm#401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
As discussed in pull #401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
As discussed in pull llvm#401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
As discussed in pull llvm#401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
As discussed in pull llvm#401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
As discussed in pull #401 , The present `UnimplementedFeature` class is made for the CIRGen submodule and we need similar facilities for code under `clang/lib/CIR/Dialect/IR`. This NFC patch adds a new `CIRDialectUnimplementedFeature` class that provides unimplemented feature guards for CIR dialect code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in pull #401 , The present
UnimplementedFeatureclass is made for the CIRGen submodule and we need similar facilities for code underclang/lib/CIR/Dialect/IR. This NFC patch adds a newCIRDialectUnimplementedFeatureclass that provides unimplemented feature guards for CIR dialect code.