-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][CIRGen] Support dynamic_cast to void ptr #442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds CIRGen for downcasting a pointer to the complete object through dynamic_cast<void *>.
bcardosolopes
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with #426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with llvm#426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with #426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with #426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with llvm#426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with #426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with llvm#426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with llvm#426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with llvm#426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This patch adds CIRGen for downcasting a pointer to the complete object through `dynamic_cast<void *>`. Together with #426 , the full functionality of `dynamic_cast` should be supported in CIRGen after this PR merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds CIRGen for downcasting a pointer to the complete object through
dynamic_cast<void *>
.Together with #426 , the full functionality of
dynamic_cast
should be supported in CIRGen after this PR merges.