Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR] replace AnyType with CIR_AnyType #371

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[CIR] replace AnyType with CIR_AnyType #371

merged 4 commits into from
Jan 9, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Dec 28, 2023

This PR addresses #90. It introduces a new type constraint CIR_AnyType which allows CIR types and MLIR floating-point types. Present AnyType constraints are replaced with the new CIR_AnyType constraint.

@Lancern
[CIR] replace AnyType with CIR_AnyType
bc54331 
This commit addresses llvm#90. It introduces a new type constraint
"CIR_AnyType" which allows CIR types and MLIR floating-point types.
Present AnyType constraints are replaced with the new CIR_AnyType
constraint.
@Lancern
Update description of CIR_StructType
d42f8f1
@Lancern
update code format
6f97b03
@Lancern
add trailing new line to CIROps.td
17f748f
sitio-couto
sitio-couto reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@sitio-couto sitio-couto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bcardosolopes
bcardosolopes approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor nit

@bcardosolopes bcardosolopes merged commit 4562fc8 into llvm:main Jan 9, 2024
6 checks passed
@Lancern Lancern deleted the cir-type-constraints branch January 10, 2024 12:43
lanza pushed a commit that referenced this pull request Jan 29, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (#371)
d4b5bc7 
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Mar 23, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (#371)
2d4adfe 
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (llvm#371)
96bb98f 
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (llvm#371)
e05262f 
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (#371)
790f7ea 
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (#371)
ea6a6fa 
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (llvm#371)
64aaf13 
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Apr 29, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (#371)
6a0e742 
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (llvm#371)
f788073 
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (llvm#371)
61be597 
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (llvm#371)
83415f6 
This PR addresses llvm#90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@Lancern @lanza
[CIR] Replace AnyType with CIR_AnyType (#371)
2c316a8 
This PR addresses #90. It introduces a new type constraint `CIR_AnyType`
which allows CIR types and MLIR floating-point types. Present `AnyType`
constraints are replaced with the new `CIR_AnyType` constraint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitio-couto sitio-couto sitio-couto left review comments

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lancern @bcardosolopes @SchrodingerZhu @sitio-couto