Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][github] Setup github test CIR workflow. #332

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

xlauko
Copy link
Collaborator

@xlauko xlauko commented Nov 21, 2023

Closes #288

The action mirrors https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml with a few minor differences:

  • it is not restricted to: github.repository_owner == 'llvm'
  • it triggers on pull requests and pushes to main instead of release branches

I suggest adding branch protection rule to require tests to pass for each pull request:
Settings -> Branches -> Add branch protection rule -> Require status checks to pass before merging

@xlauko xlauko changed the title Setup github test CIR workflow. [CIR][github] Setup github test CIR workflow. Nov 21, 2023
@bcardosolopes
Copy link
Member

This is awesome @xlauko! I like how it already caught a windows failure, let me look into that one to unblock this.

I suggest adding branch protection rule to require tests to pass for each pull request:

Good idea, will do it as soon as we land this.

@sitio-couto
Copy link
Collaborator

@xlauko, this is great (and long overdue)!

Do you think you could add a clang-format check? The main issue that tends to be overlooked in reviews is formatting.

@xlauko
Copy link
Collaborator Author

xlauko commented Nov 28, 2023

Looking into upstream llvm there is already https://github.com/llvm/llvm-project/blob/main/.github/workflows/pr-code-format.yml

I have a branch that cherry picks these changes: https://github.com/xlauko/clangir/tree/clang-format-action but maybe you want to integrate it your usual way?

@bcardosolopes
Copy link
Member

Fixed the windows issue in #337

@bcardosolopes
Copy link
Member

Looking into upstream llvm there is already https://github.com/llvm/llvm-project/blob/main/.github/workflows/pr-code-format.yml

Neat!

I have a branch that cherry picks these changes: https://github.com/xlauko/clangir/tree/clang-format-action but maybe you want to integrate it your usual way?

Perhaps we should wait until next rebase then? @lanza thoughts?

@xlauko
Copy link
Collaborator Author

xlauko commented Nov 30, 2023

Fixed the windows issue in #337

Let's see. I have rebased over the changes.

@lanza
Copy link
Member

lanza commented Nov 30, 2023

I have a branch that cherry picks these changes: https://github.com/xlauko/clangir/tree/clang-format-action but maybe you want to integrate it your usual way?

Perhaps we should wait until next rebase then? @lanza thoughts?

I'll start on the next rebase and get it that way. Shouldn't be too bad.

@bcardosolopes
Copy link
Member

I'll start on the next rebase and get it that way. Shouldn't be too bad.

Tracking in #345

@bcardosolopes bcardosolopes merged commit 0366e25 into llvm:main Nov 30, 2023
lanza pushed a commit that referenced this pull request Dec 20, 2023
Closes #288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
lanza pushed a commit that referenced this pull request Jan 29, 2024
Closes #288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
lanza pushed a commit that referenced this pull request Mar 23, 2024
Closes #288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
Closes llvm#288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
Closes llvm#288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
lanza pushed a commit that referenced this pull request Apr 29, 2024
Closes #288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
lanza pushed a commit that referenced this pull request Apr 29, 2024
Closes #288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
Closes llvm#288 

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
lanza pushed a commit that referenced this pull request Apr 29, 2024
Closes #288

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
Closes llvm#288

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
Closes llvm#288

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
Closes llvm#288

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
lanza pushed a commit that referenced this pull request Nov 5, 2024
Closes #288

The action mirrors
https://github.com/llvm/llvm-project/blob/main/.github/workflows/clang-tests.yml
with a few minor differences:
 - it is not restricted to: `github.repository_owner == 'llvm'`
- it triggers on pull requests and pushes to `main` instead of `release`
branches

I suggest adding branch protection rule to require tests to pass for
each pull request:
`Settings -> Branches -> Add branch protection rule -> Require status
checks to pass before merging`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a github action for testing CIR
4 participants