[CIR][CIRGen] Partially support statement expressions return values #314

sitio-couto · 2023-11-15T00:45:41Z

Stack from ghstack (oldest at bottom):

Adds support for GCC statement expressions return values as well as
StmtExpr LValue emissions.

To simplify the lowering process, the scope return value is not used.
Instead, a temporary allocation is created on the parent scope where the
return value is stored. For classes, a second scope is created around
this temporary allocation to ensure any destructors are called.

This does not implement the full semantics of statement expressions.

Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. ghstack-source-id: 59cb541c953907bfa4c645e5f9ec8ac36908fd46 Pull Request resolved: #314

clang/lib/CIR/CodeGen/CIRGenStmt.cpp

…310) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #314 * #313 * #312 * #311 * __->__ #310 The `shouldPrintTerm` and `checkBlockTerminator` were replaced in favor of `omitRegionTerm` and `ensureRegionTerm` respectively. The first is essentially the same method but simplified. The latter was refactored to do only two things: check if the terminator omission of a region is valid and, if so, insert the omitted terminator into the region. The simplifications mostly leverage the fact that we only omit empty yield values in a single-block region.

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. ghstack-source-id: 4baa1f9e7119e9813e790234145a18f2cf14142f Pull Request resolved: #314

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. ghstack-source-id: 4baa1f9e7119e9813e790234145a18f2cf14142f Pull Request resolved: #314

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. ghstack-source-id: 4baa1f9e7119e9813e790234145a18f2cf14142f Pull Request resolved: #314

bcardosolopes

Thanks for adding this, pretty cool! Some discussion points follow.

clang/test/CIR/CodeGen/stmt-expr.c

clang/lib/CIR/CodeGen/CIRGenStmt.cpp

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. ghstack-source-id: 57a10677f546f3d4cbc07889baabdfe9dae23810 Pull Request resolved: #314

sitio-couto · 2023-11-22T20:12:32Z

@bcardosolopes applied and answered.

clang/test/CIR/CodeGen/stmt-expr.c

bcardosolopes

One minor change and this is good!

clang/lib/CIR/CodeGen/CIRGenStmt.cpp

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: daf5fa8dc331919e12b6b54518a181f2d3a92bba Pull Request resolved: #314

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: b5a42466e749861e9610d3a70da0361d2755b1b8 Pull Request resolved: #314

bcardosolopes

LGTM! Will let you merge as to not mess up with the stack tool

…rn values" Adds support for GCC statement expressions return values by leveraging the `cir.scope` operation return value and aggregate copies. This does not implement the full semantics of statement expressions. [ghstack-poisoned]

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: #314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: llvm#314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: #314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: llvm#314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: #314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: llvm/clangir#314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: llvm#314

Adds support for GCC statement expressions return values as well as StmtExpr LValue emissions. To simplify the lowering process, the scope return value is not used. Instead, a temporary allocation is created on the parent scope where the return value is stored. For classes, a second scope is created around this temporary allocation to ensure any destructors are called. This does not implement the full semantics of statement expressions. ghstack-source-id: 64e03fc3df45975590ddbcab44959c2b49601101 Pull Request resolved: #314

sitio-couto requested a review from bcardosolopes November 15, 2023 00:46

sitio-couto commented Nov 15, 2023

View reviewed changes

clang/lib/CIR/CodeGen/CIRGenStmt.cpp Show resolved Hide resolved

sitio-couto mentioned this pull request Nov 17, 2023

[CIR][IR] Refactor parsing/printing of implicitly terminated regions #321

Merged

bcardosolopes requested changes Nov 18, 2023

View reviewed changes

clang/test/CIR/CodeGen/stmt-expr.c Outdated Show resolved Hide resolved

clang/test/CIR/CodeGen/stmt-expr.c Show resolved Hide resolved

clang/test/CIR/CodeGen/stmt-expr.c Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenStmt.cpp Show resolved Hide resolved

sitio-couto commented Dec 6, 2023

View reviewed changes

clang/test/CIR/CodeGen/stmt-expr.c Outdated Show resolved Hide resolved

bcardosolopes mentioned this pull request Dec 8, 2023

Statement expression dtor issue #350

Open

bcardosolopes requested changes Dec 8, 2023

View reviewed changes

clang/lib/CIR/CodeGen/CIRGenStmt.cpp Outdated Show resolved Hide resolved

clang/lib/CIR/CodeGen/CIRGenStmt.cpp Show resolved Hide resolved

sitio-couto requested a review from bcardosolopes January 9, 2024 18:15

bcardosolopes approved these changes Jan 10, 2024

View reviewed changes

sitio-couto merged commit c9173a5 into gh/sitio-couto/5/base Jan 10, 2024
3 checks passed

sitio-couto deleted the gh/sitio-couto/5/head branch January 10, 2024 23:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CIR][CIRGen] Partially support statement expressions return values #314

[CIR][CIRGen] Partially support statement expressions return values #314

sitio-couto commented Nov 15, 2023 •

edited

Loading

bcardosolopes left a comment

sitio-couto commented Nov 22, 2023

bcardosolopes left a comment

bcardosolopes left a comment

[CIR][CIRGen] Partially support statement expressions return values #314

[CIR][CIRGen] Partially support statement expressions return values #314

Conversation

sitio-couto commented Nov 15, 2023 • edited Loading

bcardosolopes left a comment

Choose a reason for hiding this comment

sitio-couto commented Nov 22, 2023

bcardosolopes left a comment

Choose a reason for hiding this comment

bcardosolopes left a comment

Choose a reason for hiding this comment

sitio-couto commented Nov 15, 2023 •

edited

Loading