Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen][Builtin][Neon] Lower neon_vzip_v and neon_vzipq_v #1320

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[CIR][CIRGen][Builtin][Neon] Lower neon_vzip_v and neon_vzipq_v #1320

merged 1 commit into from
Feb 11, 2025

Conversation

AmrDeveloper
Copy link
Member

Lowering builtin_neon_vzip_v and builtin_neon_vzipq_v

Clang CGBuiltin Implementation

@AmrDeveloper
Copy link
Member Author

AmrDeveloper commented Feb 7, 2025 •
edited
Loading

@ghehg Can't assign you as a reviewer, so please take a look when you are available :D

@AmrDeveloper AmrDeveloper mentioned this pull request Feb 7, 2025
Closed
@bcardosolopes bcardosolopes requested a review from ghehg February 7, 2025 21:15
bcardosolopes
bcardosolopes approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but pending on @ghehg stamp

@FantasqueX FantasqueX mentioned this pull request Feb 8, 2025
Closed
@bcardosolopes
Copy link
Member

Conflict fix needed

@bcardosolopes bcardosolopes merged commit 2c7e65e into llvm:main Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@ghehg ghehg Awaiting requested review from ghehg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmrDeveloper @bcardosolopes