Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create custom CIR floating point types. #78

Closed
sitio-couto opened this issue May 24, 2023 · 7 comments
Closed

Create custom CIR floating point types. #78

sitio-couto opened this issue May 24, 2023 · 7 comments
Assignees
@Lancern
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sitio-couto
Copy link
Collaborator

Follow up from #5 and #62

The goal is to migrate from MLIR's built-in float types to CIR customs floating point types.
@bcardosolopes bcardosolopes added enhancement New feature or request good first issue Good for newcomers labels May 24, 2023
@Ris-Bali
Copy link

Is anyone working on this ? ; if not I would like to work on this issue.

@bcardosolopes
Copy link
Member

bcardosolopes commented Jun 20, 2023 •
edited
Loading

Is anyone working on this ? ; if not I would like to work on this issue.

Hi @Ris-Bali, this is a good first issue. You can probably start by adding float support and build from there. You can find good example resources in the repo by looking at commits that introduced !cir.int types.

@sitio-couto
Copy link
Collaborator Author

@Ris-Bali nice to see someone working on this!

Regarding how to do this, MLIR's builtin floats might be a good reference.

This was referenced Jul 8, 2023
Closed
Closed
@sitio-couto sitio-couto mentioned this issue Jul 26, 2023
Merged
@bcardosolopes
Copy link
Member

@Ris-Bali any plans to continue working on this?

@Ris-Bali
Copy link

Apologies for the delay I'm working on this and will update the PR soon

@bcardosolopes bcardosolopes mentioned this issue Dec 29, 2023
Closed
@Lancern Lancern mentioned this issue Jan 6, 2024
Merged
5 tasks
bcardosolopes pushed a commit that referenced this issue Feb 21, 2024
@Lancern
[CIR] introduce CIR floating-point types (#385)
941cb1d 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.
lanza pushed a commit that referenced this issue Mar 23, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (#385)
347d829 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.
eZWALT pushed a commit to eZWALT/clangir that referenced this issue Mar 24, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (llvm#385)
b6e6a37 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: llvm#5,
llvm#78, and llvm#90.
lanza pushed a commit that referenced this issue Apr 29, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (#385)
5777784 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.
lanza pushed a commit that referenced this issue Apr 29, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (#385)
ab6226f 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.
eZWALT pushed a commit to eZWALT/clangir that referenced this issue Apr 29, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (llvm#385)
0ba447b 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: llvm#5,
llvm#78, and llvm#90.
lanza pushed a commit that referenced this issue Apr 29, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (#385)
b82fdb0 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: #5,
#78, and #90.
@Lancern
Copy link
Member

Lancern commented Sep 30, 2024

Reopen this as __fp16 is still NYI.

@Lancern Lancern reopened this Sep 30, 2024
@Lancern Lancern self-assigned this Sep 30, 2024
@Lancern
Copy link
Member

Lancern commented Sep 30, 2024

Looks like it's the wrong place to track this issue... Closing this and open another issue for tracking __fp16.

@Lancern Lancern closed this as completed Sep 30, 2024
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this issue Oct 2, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (llvm#385)
ce57e0c 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: llvm#5,
llvm#78, and llvm#90.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this issue Oct 2, 2024
@Lancern @lanza
[CIR] introduce CIR floating-point types (llvm#385)
81aecc8 
This PR adds a dedicated `cir.float` type for representing
floating-point types. There are several issues linked to this PR: llvm#5,
llvm#78, and llvm#90.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lancern Lancern

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CIR] Add support for floating point types Ris-Bali/clangir
4 participants
@bcardosolopes @Lancern @sitio-couto @Ris-Bali