[RTGTest] Add the last remaining ops for RV32I #8142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
force-pushed
the
maerhart-rtgtest-integer-register-api
branch
from
0ff91bf to
1a8407a
Compare
maerhart
force-pushed
the
maerhart-rtgtest-last-operations
branch
from
1f4427a to
32c1c81
Compare
fabianschuiki
approved these changes
Feb 3, 2025
Comment on lines
+391
to
+394
| .concat(llvm::APInt(5, rs.getClassIndex())) | ||
| .concat(llvm::APInt(3, }] # funct3 # [{)) | ||
| .concat(llvm::APInt(5, rd.getClassIndex())) | ||
| .concat(llvm::APInt(7, }] # opcode7 # [{)); |
There was a problem hiding this comment.
This might be easier to read with a TableGen subst call around the code snippet substituting something like $funct3. But then again, this is pretty clean, and there are only two values to be interpolated. The substitution might make it harder to read.
There was a problem hiding this comment.
Doing !subst("$funct3", funct3, "...") leads to a cryptic tablegen error saying that the initializer could not be resolved. Maybe because funct3 is an integer and not a string? Working around all of that might make it more complicated.
Base automatically changed from
maerhart-rtgtest-integer-register-api
to
main
February 3, 2025 07:59
maerhart
force-pushed
the
maerhart-rtgtest-last-operations
branch
from
32c1c81 to
060aa5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.