[CI] Enable Windows builds for PRs #8085
Conversation
|
From the CI results of this PR, the Windows builds only took 3 more minutes than other jobs, which is acceptable IMO. |
There was a problem hiding this comment.
They're quick in the average case (thanks to @seldridge for the caching); but, when the LLVM submodule gets updated or the cache gets flushed it'll take forever. Still worth it I think, though the informal policy should be that if the build is taking forever that it should be considered optional since most changes do not break this build.
|
I noticed that almost all of Windows CI jobs rebuild LLVM in the last couple of days, and there seems to be some problem with caching - all these jobs show sccache "No cache found". I checked https://github.com/llvm/circt/actions/caches, GitHub does warn about exceeding the free 10G quota, and it should evict earlier caches first, but there are multiple Windows caches on the page without any hits. I'm not sure why. 🤔 |
As discussed in #7970, try enabling it to detect Windows-only bugs before merging.