[Verif] disambiguate ctor

[makslevental]

clang-tidy reports this ctor call as ambiguous and in fact it fails on Windows with clang-cl with

  D:\a\circt\circt\lib\Conversion\VerifToSV\VerifToSV.cpp(48,22): error: call to constructor of 'APInt' is ambiguous
     48 |         op.getLoc(), APInt(32, 0x80000001, false));
        |                      ^     ~~~~~~~~~~~~~~~~~~~~~
  D:\a\circt\circt\llvm\llvm\include\llvm/ADT/APInt.h(157,3): note: candidate constructor
    157 |   APInt(unsigned numBits, unsigned numWords, const uint64_t bigVal[]);
        |   ^
  D:\a\circt\circt\llvm\llvm\include\llvm/ADT/APInt.h(111,3): note: candidate constructor
    111 |   APInt(unsigned numBits, uint64_t val, bool isSigned = false,
        |   ^
  1 error generated.

[maerhart]

Interesting that this doesn't work properly on windows, but since 'false' is the default anyway this LGTM.

[makslevental]

Interesting that this doesn't work properly on windows, but since 'false' is the default anyway this LGTM.

Presumably it does work on msvc.exe because you guys have tests? But yea not sure why clang-cl.exe complains (and then what's funnier/weirder is that it doesn't fail for clang on Linux/Mac 🤷).

[makslevental]

BTW there's actually another blocker on this path:

  lld-link: error: undefined symbol: public: __cdecl mlir::SuccessorRange::SuccessorRange(class mlir::Operation *)

  >>> referenced by D:\a\circt\circt\lib\Bindings\Python\ESIModule.cpp

  >>>               tools\circt\lib\Bindings\Python\CMakeFiles\CIRCTPythonModules.extension._circt.dso.dir\ESIModule.cpp.obj

  >>> referenced by D:\a\circt\circt\lib\Bindings\Python\MSFTModule.cpp

  >>>               tools\circt\lib\Bindings\Python\CMakeFiles\CIRCTPythonModules.extension._circt.dso.dir\MSFTModule.cpp.obj

  >>> referenced by D:\a\circt\circt\lib\Bindings\Python\SVModule.cpp

  >>>               tools\circt\lib\Bindings\Python\CMakeFiles\CIRCTPythonModules.extension._circt.dso.dir\SVModule.cpp.obj

but I'll come back to that one later because it's tougher to fix.