[ExtractInstances] Append original instance name to path in metadata #7872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
requested review from
mikeurbach
and removed request for
seldridge and
darthscsi
mikeurbach
approved these changes
Nov 21, 2024
darthscsi
reviewed
Dec 14, 2024
| @@ -1175,9 +1186,10 @@ void ExtractInstancesPass::createSchema() { | |||
| mlir::Type portsType[] = { | |||
| StringType::get(context), // name | |||
| PathType::get(context), // extracted instance path | |||
| StringType::get(context) // filename | |||
| StringType::get(context), // filename | |||
There was a problem hiding this comment.
Please call get once and reuse the value. Type uniquing has costs we don't need to pay here.
There was a problem hiding this comment.
Thanks for spotting this, fixed it.
prithayan
force-pushed
the
dev/pbarua/fixup_extract_instances_metadata
branch
from
8d58bdd to
ec936ab
Compare
|
Thanks for the review, and Sorry for the delay in resolving this PR. I was waiting on some other changes to the client consuming the metadata files. Going to merge this after the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the metadata generated by
ExtractInstances.Currently the path in the metadata, doesn't contain the original instance name, which causes difficulty in distinguishing extracted instances within the same module.
This PR updates the metadata to append the original instance name to the path.
Note that this instance name is of the instance, that has been extracted, hence it cannot be represented by the Hierarchical path.