[FIRRTL] Refactor class lowering to avoid unnecessary cloning #7823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the class lowering logic by directly moving or cloning operations instead of cloning the entire module body. This change: - Removes the need to clone the entire module region - Only clones instance operations that need to be preserved - Directly moves property operations to the OM class - Removes redundant block cleanup
youngar
reviewed
Nov 15, 2024
Comment on lines
+1242
to
+1249
| for (auto &op : | ||
| llvm::make_early_inc_range(llvm::reverse(moduleLike.getOperation() | ||
| ->getRegion(0) | ||
| .getBlocks() | ||
| .front() | ||
| .getOperations()))) | ||
| if (isPropertyOp(op) && !isa<InstanceOp>(op)) | ||
| op.erase(); |
There was a problem hiding this comment.
Just making sure, is there anything to erase in the original module, since we're moving all the property operations?
There was a problem hiding this comment.
Good point, I think this is dead code now.
rwy7
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the class lowering logic by directly moving or cloning operations
instead of cloning the entire module body. This change: