[Comb][Fold] Fix idemp n^2 and bugfix + more optimization. #7514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix n^2 behavior with canonicalizeIdempotentInputs. Add arbitrary "depth" check to bound the search. * Don't allow flattening or idempotent to search into operations defined in other blocks. * Support removing duplicates even when operands come from other blocks. (or(x, y, x) -> or(x, x) regardless of their origin). * Don't walk into operations with different two-state-ness in the idempotent operand canonicalizer. * When creating new operation in idempotent canonicalizer, create it with matching two-state-ness. Add tests for functional changes above.
dtzSiFive
force-pushed
the
feature/idem-depth
branch
from
0d0a5aa to
2cdb5c9
Compare
uenoku
approved these changes
Aug 13, 2024
|
Thanks! |
|
(This was tested on various internal designs, and looks good, FWIW!) |
|
Really nice fix! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for functional changes above.