-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump llvm to tip of main #7440
bump llvm to tip of main #7440
Conversation
try adding |
Looks like there are some passes doing some things that are not compatible with upstream LLVM changes. Can you take a look please: MooreToCore - @fabianschuiki @maerhart @mortbopet for the latter I reduced it to this failing case:
|
@@ -187,7 +186,7 @@ class FlattenIOTypeConverter : public TypeConverter { | |||
ValueRange inputs, Location loc) { | |||
auto structType = getStructType(type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This would be unused in a non-assert build.
Thanks for fixing this @fabianschuiki ! LGTM! |
@fabianschuiki can you help with the merge conflict? Should i just take what is on |
@mwachs5 Looks like that did the trick! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for going through all this pain @mwachs5 🥳 🙌 !
Co-authored-by: Fabian Schuiki <[email protected]>
Thank you, @mwachs5 !!! Sorry this was a rougher one! |
No description provided.