Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Touchup {parse,emit}-basic.fir for --parse-only. #7397

Merged
merged 1 commit into from
Jul 29, 2024
Merged

[FIRRTL] Touchup {parse,emit}-basic.fir for --parse-only. #7397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/Dialect/FIRRTL/emit-basic.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,8 @@ firrtl.circuit "Foo" {
%d = firrtl.double 0.333333333333333333333333333333333333333
firrtl.propassign %double, %d : !firrtl.double

// CHECK: propassign path, path("OMDeleted")
%p = firrtl.unresolved_path "OMDeleted"
// CHECK: propassign path, path("OMDeleted:")
%p = firrtl.unresolved_path "OMDeleted:"
firrtl.propassign %path, %p : !firrtl.path

// CHECK: propassign list,
Expand Down
8 changes: 4 additions & 4 deletions test/Dialect/FIRRTL/parse-basic.fir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,9 +1576,9 @@ circuit BasicProps :
module Path :
; CHECK-SAME: out %path: !firrtl.path
output path : Path
; CHECK: firrtl.unresolved_path "OMDeleted"
; CHECK: firrtl.unresolved_path "OMDeleted:"
; CHECK: firrtl.propassign %path, %0 : !firrtl.path
propassign path, path("OMDeleted")
propassign path, path("OMDeleted:")

; CHECK-LABEL: firrtl.class private @SimpleClass(in %a: !firrtl.string, out %b: !firrtl.string) {
; CHECK-NEXT: firrtl.propassign %b, %a : !firrtl.string
Expand Down Expand Up @@ -1895,9 +1895,9 @@ circuit GenericIntrinsics:
; CHECK-NEXT: %[[PAV:.+]] = firrtl.int.generic "circt_plusargs_value" <FORMAT: none = "foo"> : () -> !firrtl.bundle<found: uint<1>, result: uint<5>>
; CHECK-NEXT: %n = firrtl.node interesting_name %[[PAV]]
node n = intrinsic(circt_plusargs_value<FORMAT = "foo"> : { found : UInt<1>, result : UInt<5> })
; CHECK-NEXT: %[[PAT:.+]] = firrtl.int.generic "circt_plusargs_test" <FORMAT: none = "bar"> : () -> !firrtl.uint<3>
; CHECK-NEXT: %[[PAT:.+]] = firrtl.int.generic "circt_plusargs_test" <FORMAT: none = "bar"> : () -> !firrtl.uint<1>
; CHECK-NEXT: %n2 = firrtl.node interesting_name %[[PAT]]
node n2 = intrinsic(circt_plusargs_test<FORMAT = "bar"> : UInt<3>)
node n2 = intrinsic(circt_plusargs_test<FORMAT = "bar"> : UInt<1>)


; Statement with unused return value.
Expand Down
Loading