[LLHD] Use hw.inout instead of llhd.sig #7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Jul 19, 2024
| }]> | ||
| ]; | ||
| } | ||
|
|
||
| // Declares the llhd::PtrType in C++. | ||
| def PtrTypeImpl : LLHDType<"Ptr"> { |
There was a problem hiding this comment.
Do you think we might be able to use memrefs as a replacement for !llhd.ptr in the future?
There was a problem hiding this comment.
In theory yes, but we might not want to pull in all the complexity of memref in practice.
maerhart
force-pushed
the
maerhart-replace-sig-with-inout
branch
from
48a309f to
a1ab29f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to better integrate LLHD into the core dialects and is a preparation for other LLHD dialect refactorings (e.g., removing
llhd.entityand usinghw.moduleinstead).