Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HW] Clean up HWTypes, NFC #7209

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[HW] Clean up HWTypes, NFC #7209

merged 1 commit into from
Jun 20, 2024

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Jun 19, 2024

  • Port some of customAssemblyFormat to declarative assembly-format. HW uses unconventional printer so we still need to use custom directive though.
  • Use TypeBuilderWithInferredContext
  • Make banner consistent with others

@uenoku uenoku requested a review from darthscsi as a code owner June 19, 2024 17:14
@uenoku uenoku force-pushed the dev/hidetou/clean-up-hw-types branch from 2672ee0 to 4986a53 Compare June 19, 2024 17:16
dtzSiFive
dtzSiFive approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Didn't super-carefully compare the before/after printing/parsing logic but the diff looks right and thanks for cleaning this up!

@uenoku
Copy link
Member Author

uenoku commented Jun 20, 2024

Thank you for review!

@uenoku uenoku merged commit 62cb3d1 into main Jun 20, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/clean-up-hw-types branch June 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uenoku @dtzSiFive