[FIRRTL][SpecializeLayers] Fix incorrect CF leading to double free #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a part of specializing layers we have to remove any HierPathOps which included a reference to deleted instances. If any member of the path array is contained in the deleted references list, we need to delete the op. There was incorrect use of `continue` which caused us to continue processing the path instead of skipping to the next path operation, which could lead to a double free when multiple instances in the path were removed.
uenoku
pushed a commit
that referenced
this pull request
Jul 3, 2024
…7200) As a part of specializing layers we have to remove any HierPathOps which included a reference to deleted instances. If any member of the path array is contained in the deleted references list, we need to delete the op. There was incorrect use of `continue` which caused us to continue processing the path instead of skipping to the next path operation, which could lead to a double free when multiple instances in the path were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of specializing layers we have to remove any HierPathOps which included a reference to deleted instances. If any member of the path array is contained in the deleted references list, we need to delete the op. There was incorrect use of
continuewhich caused us to continue processing the path instead of skipping to the next path operation, which could lead to a double free when multiple instances in the path were removed.