Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][InjectDUT] Fix w/references, use emitConnect. #4912

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[FIRRTL][InjectDUT] Fix w/references, use emitConnect. #4912

merged 1 commit into from
Mar 31, 2023

Conversation

dtzSiFive
Copy link
Contributor

Add regression test.

seldridge
seldridge approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm glad this was a trivial change. emitConnect paying dividends. 😉

@dtzSiFive dtzSiFive merged commit 1360e01 into llvm:main Mar 31, 2023
@dtzSiFive dtzSiFive deleted the fix/inject-dut-refs branch March 31, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @seldridge