Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Add folders for bundle/vector create #4908

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[FIRRTL] Add folders for bundle/vector create #4908

merged 2 commits into from
Mar 31, 2023

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Mar 30, 2023 •
edited
Loading

Add folders for aggregate create operations:

vector_create(%foo[0], %foo[1]) -> %foo : vec<uint<2>, 2>
bundle_create(%foo["a"], %foo["b"]) -> %foo : bundle<a:uint<1>, b:uint<1>>

@uenoku uenoku marked this pull request as ready for review March 30, 2023 14:30
dtzSiFive
dtzSiFive approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@uenoku uenoku force-pushed the dev/uenoku/tmp-fold branch from 2d0a87c to 7cc9566 Compare March 31, 2023 11:39
@uenoku uenoku merged commit 6bd73ce into main Mar 31, 2023
@uenoku uenoku deleted the dev/uenoku/tmp-fold branch March 31, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uenoku @dtzSiFive