-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIRRTL][GCT] Add support for tapping non-passive bundles, add test. #4815
Conversation
9374b86
to
c6a7974
Compare
Only draft until support piece is in, FWIW. |
Tap sink must be passive.
c6a7974
to
aacaf91
Compare
Idea is to support what could also be done w/probes. Anyway, this would introduce a difference in behavior regarding what's connectable with and without the hidden
This probably should be rejected for DataTap's, may make sense for LegacyWiringProblem's that don't have multiple sinks (ambiguous which sink's flipped fields should drive the source)? |
Welp, we presently crash on the above input w/o the hidden flag, so ... progress! |
@@ -841,6 +841,14 @@ LogicalResult LowerAnnotationsPass::solveWiringProblems(ApplyState &state) { | |||
return failure(); | |||
} | |||
} | |||
// If wiring using references, check that the sink value we connect to is | |||
// passive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can totally support some non-passive sinks (driving all fields individually) in the future, at least as long as it's not a port or something. Don't think it's worth supporting until there's a need/ask.
Test introduced in #4815. 1) CHECK-DAG-SAME doesn't exist/work. 2) Test check line was wrong anyway.
Builds on #4801 .
Relevant commit: c6a7974 .