Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HWLegalizeModules] Legalize aggregate constant #4626

Merged

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Feb 6, 2023

This PR extends HWLegalizeModules to support aggregate constants. Also signalPassFailure is called when we fail to legalize expressions.

Fix #4623.

@uenoku uenoku merged commit 2b612a2 into main Feb 7, 2023
@uenoku uenoku deleted the dev/hidetou/lower-aggregate-constant-in-disallowPackedArrays branch February 7, 2023 10:56
@harrisonliew harrisonliew mentioned this pull request Feb 9, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIRRTL] lowering-options=disallowPackedArrays not erroring properly
1 participant