feat(syncer): add a syncer to reflect job status in local resources #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaneda
approved these changes
Jan 29, 2025
| }) | ||
| } | ||
|
|
||
| if err := eg.Wait(); err != nil { |
There was a problem hiding this comment.
eg.Wait() waits until all goroutines complete, but I think we want to return an error once one of them completes.
https://pkg.go.dev/golang.org/x/sync/errgroup#Group.Wait
If this makes sense, could you add a TODO comment?
There was a problem hiding this comment.
This error group is created with a context in L44. The contexts are canceled when the group receives a first error, and the status syner uses that context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.