Fixes SQL error from rails 5.2 upgrade CanCanCommunity#478

.travis.yml

@@ -12,6 +12,7 @@ gemfile:
   - gemfiles/activerecord_4.2.gemfile
   - gemfiles/activerecord_5.0.2.gemfile
   - gemfiles/activerecord_5.1.0.gemfile
+  - gemfiles/activerecord_5.2.0.beta2.gemfile
 services:
   - mongodb
 matrix:
@@ -33,6 +34,10 @@ matrix:
       gemfile: gemfiles/activerecord_5.1.0.gemfile
     - rvm: jruby-9.1.9.0
       gemfile: gemfiles/activerecord_5.1.0.gemfile
+    - rvm: jruby-9.0.5.0
+      gemfile: gemfiles/activerecord_5.2.0.beta2.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/activerecord_5.2.0.beta2.gemfile
 notifications:
   email:
     recipients:

Appraisals

@@ -46,3 +46,19 @@ appraise 'activerecord_5.1.0' do
     gem 'pg', '~> 0.21'
   end
 end
+
+appraise 'activerecord_5.2.0.beta2' do
+  gem 'activerecord', '~> 5.2.0.beta2', require: 'active_record'
+  gem 'activesupport', '~> 5.2.0.beta2', require: 'active_support/all'
+  gem 'actionpack', '~> 5.2.0.beta2', require: 'action_pack'
+
+  gemfile.platforms :jruby do
+    gem 'activerecord-jdbcsqlite3-adapter'
+    gem 'jdbc-sqlite3'
+  end
+
+  gemfile.platforms :ruby, :mswin, :mingw do
+    gem 'sqlite3'
+    gem 'pg', '~> 0.21'
+  end
+end

gemfiles/activerecord_5.2.0.beta2.gemfile

@@ -0,0 +1,19 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activerecord", "~> 5.2.0.beta2", require: "active_record"
+gem "activesupport", "~> 5.2.0.beta2", require: "active_support/all"
+gem "actionpack", "~> 5.2.0.beta2", require: "action_pack"
+
+platforms :jruby do
+  gem "activerecord-jdbcsqlite3-adapter"
+  gem "jdbc-sqlite3"
+end
+
+platforms :ruby, :mswin, :mingw do
+  gem "sqlite3"
+  gem "pg", "~> 0.21"
+end
+
+gemspec path: "../"

lib/cancan/model_adapters/active_record_4_adapter.rb

@@ -71,9 +71,20 @@ def sanitize_sql_activerecord5(conditions)
         conditions.stringify_keys!
 
         predicate_builder.build_from_hash(conditions).map do |b|
-          @model_class.send(:connection).visitor.compile b
+          visit_nodes(b)
         end.join(' AND ')
       end
+
+      def visit_nodes(b)
+        # Rails 5.2 adds a BindParam node that prevents the visitor method from properly compiling the SQL query
+        if ActiveRecord::VERSION::MINOR >= 2
+          connection = @model_class.send(:connection)
+          collector = Arel::Collectors::SubstituteBinds.new(connection, Arel::Collectors::SQLString.new)
+          connection.visitor.accept(b, collector).value
+        else
+          @model_class.send(:connection).visitor.compile(b)
+        end
+      end
     end
   end
 end