Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC updates #314

Merged
merged 5 commits into from
Oct 31, 2024
Merged

RPC updates #314

merged 5 commits into from
Oct 31, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Oct 28, 2024 •
edited
Loading

  • remove ms from response timeout param name to align with platform conventions
  • use an interface for params to performRpc to improve param name clarity
  • bundle invocation args into a data class to provide flexibility for adding more args in the future without breaking existing code

@bcherry bcherry requested a review from nbsp October 28, 2024 19:58
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e533612

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bcherry bcherry requested a review from theomonnom October 28, 2024 20:00
@bcherry bcherry changed the title Rename responseTimeoutMs to responseTimeout RPC updates Oct 28, 2024
@bcherry bcherry merged commit 8d745bf into main Oct 31, 2024
11 checks passed
@bcherry bcherry deleted the bcherry/response-timeout branch October 31, 2024 21:50
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

@nbsp nbsp Awaiting requested review from nbsp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcherry @theomonnom