Log WHIP user agent and RTP packet if unmarshalling fails (#274)

livekit · Jun 4, 2024 · 6648e2b · 6648e2b
1 parent 44a16e9
commit 6648e2b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/whip/relay_whip_track_handler.go b/pkg/whip/relay_whip_track_handler.go
@@ -270,6 +270,7 @@ func (t *RelayWhipTrackHandler) pushRTP(pkt *rtp.Packet) error {
 
 			buf, err := t.depacketizer.Unmarshal(pkt.Payload)
 			if err != nil {
+				logger.Warnw("failed unmarshalling RTP payload", err, "pkt", pkt, "payload", pkt.Payload[:min(len(pkt.Payload), 20)])
 				return err
 			}
 

diff --git a/pkg/whip/server.go b/pkg/whip/server.go
@@ -310,7 +310,7 @@ func (s *WHIPServer) handleNewWhipClient(w http.ResponseWriter, r *http.Request,
 		return err
 	}
 
-	logger.Debugw("new whip request", "streamKey", streamKey, "sdpOffer", sdpOffer.String())
+	logger.Debugw("new whip request", "streamKey", streamKey, "sdpOffer", sdpOffer.String(), "userAgent", r.Header.Get("User-Agent"))
 
 	resourceId, sdp, err := s.createStream(streamKey, sdpOffer.String())
 	if err != nil {