Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build fuzzymatch-rs with stable rust #168

Closed
rabbitinspace opened this issue Dec 16, 2019 · 1 comment
Closed

Failed to build fuzzymatch-rs with stable rust #168

rabbitinspace opened this issue Dec 16, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@rabbitinspace
Copy link

Environment (please complete the following information):

  • OS: Arch 5.4.2-arch1-1
  • NeoVim version: v0.4.3
  • vim-clap version: master e93e4f1
  • Have you reproduced with a minimal vimrc: Yes

Describe the bug
Right now run-cargo task trying to build fuzzymatch-rs crate using stable rust but fails due to pyo3 requires nightly compiler: PyO3/pyo3#5. As a result call to clap#helper#build_all does not build the extension.

To Reproduce
Easiest way is to cd into pythonx/clap and run make build.

Or:

  1. Create the minimal vimrc min.vim:
set nocompatible
syntax on
filetype plugin indent on

call plug#begin(stdpath('data') . '/plugged') 
Plug 'liuchengxu/vim-clap', { 'do': function('clap#helper#build_all') }
call plug#end() 
  1. Start Neovim with command: nvim -u min.vim

  2. Type :PlugInstall

  3. See error

cargo build --release
    Finished release [optimized] target(s) in 0.01s
cd pythonx/clap && make build
make[1]: Entering directory '/home/rbbtnspc/.local/share/nvim/plugged/vim-clap/pythonx/clap'
\033[1;34m==>\033[0m Trying to build rust extension
   Compiling pyo3 v0.8.3
error: failed to run custom build command for `pyo3 v0.8.3`

Caused by:
  process didn't exit successfully: `/home/rbbtnspc/.local/share/nvim/plugged/vim-clap/pythonx/clap/fuzzymatch-rs/target/release/build/pyo3-8022947417df982e/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Error: pyo3 requires a nightly or dev version of Rust.', /home/rbbtnspc/.cargo/registry/src/github.jparrowsec.cn-1ecc6299db9ec823/pyo3-0.8.3/build.rs:542:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

make[1]: *** [Makefile:18: run-cargo] Error 101
make[1]: Leaving directory '/home/rbbtnspc/.local/share/nvim/plugged/vim-clap/pythonx/clap'
make: *** [Makefile:7: rust-ext] Error 2

Expected behavior
It's expected that the extension will build successfully

Additional information
Building the crate with cargo +nightly build --release fixes the issue but requires nightly compiler.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant