fix: address __slots__ and __all__ misconfigurations

.pre-commit-config.yaml

@@ -39,13 +39,55 @@ repos:
     rev: v0.3.1
     hooks:
       - id: ensure-dunder-all
-        exclude: "test*|examples*|tools"
+        # Need to be careful to not exclude too many files
+        # since "litestar" containts the word "test"
+        exclude: "test_|tests|examples|tools"
         args: ["--use-tuple"]
   - repo: https://github.com/ariebovenberg/slotscheck
     rev: v0.19.0
     hooks:
       - id: slotscheck
-        exclude: "test_*|docs|.github"
+        # Need to be careful to not exclude too many files
+        # since "litestar" containts the word "test"
+        exclude: "test_|tests|docs|.github|^tools"
+        additional_dependencies:
+          - anyio>=3
+          - httpx>=0.22
+          - exceptiongroup
+          - importlib-metadata
+          - importlib-resources>=5.12.0
+          - msgspec>=0.18.2
+          - multidict>=6.0.2
+          - polyfactory>=2.6.3
+          - pyyaml
+          - typing-extensions
+          - click
+          - rich>=13.0.0
+          - rich-click
+          - annotated-types
+          - attrs
+          - brotli
+          - jsbeautifier
+          - uvicorn[standard]
+          - uvloop>=0.18.0; sys_platform != 'win32'
+          - cryptography
+          - jinja2>=3.1.2
+          - python-jose
+          - mako>=1.2.4
+          - minijinja>=1.0.0
+          - opentelemetry-instrumentation-asgi
+          - piccolo
+          - picologging
+          - prometheus-client
+          - pydantic
+          - email-validator
+          - pydantic-extra-types
+          - redis[hiredis]>=4.4.4
+          - advanced-alchemy>=0.2.2,<1.0.0
+          - structlog
+          - asyncpg
+          - psycopg
+          - docutils
   - repo: https://github.com/sphinx-contrib/sphinx-lint
     rev: "v0.9.1"
     hooks:

litestar/__main__.py

@@ -1,5 +1,7 @@
 from litestar.cli.main import litestar_group
 
+__all__ = ("run_cli",)
+
 
 def run_cli() -> None:
     """Application Entrypoint."""

litestar/_openapi/datastructures.py

@@ -6,6 +6,13 @@
 from litestar.exceptions import ImproperlyConfiguredException
 from litestar.openapi.spec import Reference, Schema
 
+__all__ = (
+    "OpenAPIContext",
+    "RegisteredSchema",
+    "SchemaRegistry",
+)
+
+
 if TYPE_CHECKING:
     from litestar.openapi import OpenAPIConfig
     from litestar.plugins import OpenAPISchemaPluginProtocol

litestar/_openapi/plugin.py

@@ -9,6 +9,9 @@
 from litestar.plugins.base import ReceiveRoutePlugin
 from litestar.routes import HTTPRoute
 
+__all__ = ("OpenAPIPlugin",)
+
+
 if TYPE_CHECKING:
     from litestar.app import Litestar
     from litestar.config.app import AppConfig

litestar/_openapi/schema_generation/plugins/dataclass.py

@@ -7,6 +7,9 @@
 from litestar.typing import FieldDefinition
 from litestar.utils.predicates import is_optional_union
 
+__all__ = ("DataclassSchemaPlugin",)
+
+
 if TYPE_CHECKING:
     from litestar._openapi.schema_generation import SchemaCreator
     from litestar.openapi.spec import Schema

litestar/_openapi/schema_generation/plugins/pagination.py

@@ -6,6 +6,9 @@
 from litestar.pagination import ClassicPagination, CursorPagination, OffsetPagination
 from litestar.plugins import OpenAPISchemaPlugin
 
+__all__ = ("PaginationSchemaPlugin",)
+
+
 if TYPE_CHECKING:
     from litestar._openapi.schema_generation import SchemaCreator
     from litestar.typing import FieldDefinition

litestar/_openapi/schema_generation/plugins/struct.py

@@ -10,6 +10,9 @@
 from litestar.typing import FieldDefinition
 from litestar.utils.predicates import is_optional_union
 
+__all__ = ("StructSchemaPlugin",)
+
+
 if TYPE_CHECKING:
     from msgspec.structs import FieldInfo
 

litestar/_openapi/schema_generation/plugins/typed_dict.py

@@ -5,6 +5,9 @@
 from litestar.plugins import OpenAPISchemaPlugin
 from litestar.typing import FieldDefinition
 
+__all__ = ("TypedDictSchemaPlugin",)
+
+
 if TYPE_CHECKING:
     from litestar._openapi.schema_generation import SchemaCreator
     from litestar.openapi.spec import Schema

litestar/_openapi/schema_generation/schema.py

@@ -65,6 +65,14 @@
     make_non_optional_union,
 )
 
+__all__ = (
+    "SchemaCreator",
+    "create_enum_schema",
+    "create_literal_schema",
+    "create_schema_for_annotation",
+)
+
+
 if TYPE_CHECKING:
     from litestar._openapi.datastructures import OpenAPIContext
     from litestar.openapi.spec import Example, Reference

litestar/_signature/types.py

@@ -4,6 +4,8 @@
 
 from msgspec import ValidationError
 
+__all__ = ("ExtendedMsgSpecValidationError",)
+
 
 class ExtendedMsgSpecValidationError(ValidationError):
     def __init__(self, errors: list[dict[str, Any]]) -> None:

litestar/app.py

@@ -150,21 +150,17 @@ class Litestar(Router):
         "csrf_config",
         "event_emitter",
         "get_logger",
-        "include_in_schema",
         "logger",
         "logging_config",
         "multipart_form_part_limit",
         "on_shutdown",
         "on_startup",
         "openapi_config",
-        "request_class",
         "response_cache_config",
         "route_map",
-        "signature_namespace",
         "state",
         "stores",
         "template_engine",
-        "websocket_class",
         "pdb_on_exception",
         "experimental_features",
     )

litestar/channels/backends/asyncpg.py

@@ -10,6 +10,8 @@
 from litestar.channels import ChannelsBackend
 from litestar.exceptions import ImproperlyConfiguredException
 
+__all__ = ("AsyncPgChannelsBackend",)
+
 
 class AsyncPgChannelsBackend(ChannelsBackend):
     _listener_conn: asyncpg.Connection

litestar/channels/backends/base.py

@@ -3,6 +3,8 @@
 from abc import ABC, abstractmethod
 from typing import AsyncGenerator, Iterable
 
+__all__ = ("ChannelsBackend",)
+
 
 class ChannelsBackend(ABC):
     @abstractmethod

litestar/channels/backends/memory.py

@@ -6,6 +6,8 @@
 
 from litestar.channels.backends.base import ChannelsBackend
 
+__all__ = ("MemoryChannelsBackend",)
+
 
 class MemoryChannelsBackend(ChannelsBackend):
     """An in-memory channels backend"""

litestar/channels/backends/psycopg.py

@@ -7,6 +7,8 @@
 
 from .base import ChannelsBackend
 
+__all__ = ("PsycoPgChannelsBackend",)
+
 
 def _safe_quote(ident: str) -> str:
     return '"{}"'.format(ident.replace('"', '""'))  # sourcery skip

litestar/channels/backends/redis.py

@@ -13,6 +13,13 @@
 
 from litestar.channels.backends.base import ChannelsBackend
 
+__all__ = (
+    "RedisChannelsBackend",
+    "RedisChannelsPubSubBackend",
+    "RedisChannelsStreamBackend",
+)
+
+
 if TYPE_CHECKING:
     from redis.asyncio import Redis
     from redis.asyncio.client import PubSub

litestar/channels/plugin.py

@@ -16,6 +16,12 @@
 
 from .subscriber import BacklogStrategy, EventCallback, Subscriber
 
+__all__ = (
+    "ChannelsException",
+    "ChannelsPlugin",
+)
+
+
 if TYPE_CHECKING:
     from types import TracebackType
 

litestar/channels/subscriber.py

@@ -6,6 +6,12 @@
 from contextlib import AsyncExitStack, asynccontextmanager, suppress
 from typing import TYPE_CHECKING, Any, AsyncGenerator, Awaitable, Callable, Generic, Literal, TypeVar
 
+__all__ = (
+    "AsyncDeque",
+    "Subscriber",
+)
+
+
 if TYPE_CHECKING:
     from litestar.channels import ChannelsPlugin
 

litestar/contrib/attrs/attrs_schema_plugin.py

@@ -7,6 +7,9 @@
 from litestar.typing import FieldDefinition
 from litestar.utils import is_attrs_class, is_optional_union
 
+__all__ = ("AttrsSchemaPlugin",)
+
+
 try:
     import attr
     import attrs

litestar/contrib/opentelemetry/middleware.py

@@ -24,8 +24,6 @@
 class OpenTelemetryInstrumentationMiddleware(AbstractMiddleware):
     """OpenTelemetry Middleware."""
 
-    __slots__ = ("open_telemetry_middleware",)
-
     def __init__(self, app: ASGIApp, config: OpenTelemetryConfig) -> None:
         """Middleware that adds OpenTelemetry instrumentation to the application.
 

litestar/contrib/pydantic/pydantic_di_plugin.py

@@ -7,6 +7,8 @@
 from litestar.contrib.pydantic.utils import is_pydantic_model_class
 from litestar.plugins import DIPlugin
 
+__all__ = ("PydanticDIPlugin",)
+
 
 class PydanticDIPlugin(DIPlugin):
     def has_typed_init(self, type_: Any) -> bool:

litestar/contrib/pydantic/pydantic_init_plugin.py

@@ -14,6 +14,14 @@
 from litestar.typing import _KWARG_META_EXTRACTORS
 from litestar.utils import is_class_and_subclass
 
+__all__ = (
+    "ConstrainedFieldMetaExtractor",
+    "PydanticInitPlugin",
+    "is_pydantic_v1_model_class",
+    "is_pydantic_v2_model_class",
+)
+
+
 try:
     # check if we have pydantic v2 installed, and try to import both versions
     import pydantic as pydantic_v2

litestar/contrib/pydantic/pydantic_schema_plugin.py

@@ -20,6 +20,9 @@
 from litestar.typing import FieldDefinition
 from litestar.utils import is_class_and_subclass, is_generic
 
+__all__ = ("PydanticSchemaPlugin",)
+
+
 try:
     # check if we have pydantic v2 installed, and try to import both versions
     import pydantic as pydantic_v2

litestar/contrib/pydantic/utils.py

@@ -17,6 +17,19 @@
     normalize_type_annotation,
 )
 
+__all__ = (
+    "create_field_definitions_for_computed_fields",
+    "is_pydantic_2_model",
+    "is_pydantic_constrained_field",
+    "is_pydantic_model_class",
+    "is_pydantic_model_instance",
+    "is_pydantic_undefined",
+    "pydantic_get_type_hints_with_generics_resolved",
+    "pydantic_get_unwrapped_annotation_and_type_hints",
+    "pydantic_unwrap_and_get_origin",
+)
+
+
 # isort: off
 try:
     from pydantic import v1 as pydantic_v1

litestar/contrib/sqlalchemy/plugins/init/config/compat.py

@@ -4,6 +4,9 @@
 
 from litestar.utils.deprecation import deprecated
 
+__all__ = ("HasGetEngine",)
+
+
 if TYPE_CHECKING:
     from sqlalchemy import Engine
     from sqlalchemy.ext.asyncio import AsyncEngine

litestar/dto/_types.py

@@ -5,6 +5,19 @@
 
 from litestar.dto.data_structures import DTOFieldDefinition
 
+__all__ = (
+    "CollectionType",
+    "CompositeType",
+    "MappingType",
+    "NestedFieldInfo",
+    "SimpleType",
+    "TransferDTOFieldDefinition",
+    "TransferType",
+    "TupleType",
+    "UnionType",
+)
+
+
 if TYPE_CHECKING:
     from typing import Any
 
@@ -96,9 +109,6 @@ class MappingType(CompositeType):
 @dataclass(frozen=True)
 class TransferDTOFieldDefinition(DTOFieldDefinition):
     __slots__ = (
-        "default_factory",
-        "dto_field",
-        "model_name",
         "is_excluded",
         "is_partial",
         "serialization_name",

litestar/dto/data_structures.py

@@ -5,6 +5,12 @@
 
 from litestar.typing import FieldDefinition
 
+__all__ = (
+    "DTOData",
+    "DTOFieldDefinition",
+)
+
+
 if TYPE_CHECKING:
     from typing import Any, Callable
 

litestar/handlers/websocket_handlers/_utils.py

@@ -12,6 +12,15 @@
 from litestar.utils import ensure_async_callable
 from litestar.utils.helpers import unwrap_partial
 
+__all__ = (
+    "ListenerHandler",
+    "create_handle_receive",
+    "create_handle_send",
+    "create_handler_signature",
+    "create_stub_dependency",
+)
+
+
 if TYPE_CHECKING:
     from litestar import WebSocket
     from litestar.handlers.websocket_handlers.listener import WebsocketListenerRouteHandler