P 1275 omni bridge precompile #3254
Conversation
|
only ts-test require small adjust. All other code should be ready fro review. |
| fn pay_in( | ||
| handle: &mut impl PrecompileHandle, | ||
| amount: U256, | ||
| dest_id: u8, |
There was a problem hiding this comment.
We can live with it for now - is there a more general way of mapping the ChainType in pallet code?
Imagine we want to bridge to some non-evm chain later
There was a problem hiding this comment.
Then we should define the type id for all different types of chain category, and hard code mapping it in precompile.
There was a problem hiding this comment.
for evm interface, adding one extra parameter by that time.
| amount: U256, | ||
| dest_id: u8, | ||
| native: bool, | ||
| asset_id: U256, |
There was a problem hiding this comment.
Actually the same problem:
we either have native == true, or non-native with asset_id, it's actually an enum
There was a problem hiding this comment.
in evm contract, there is no ethereum struct can 100% consistently support rust enum.
we have { native, id(u32) }, this enum in rust carry extra parameter u32.
There was a problem hiding this comment.
dest_id share this problem too.
{ heima, Ethereum(chain_id) } carry extra chain_id info.
|
@0xverin ideally you could take a look at the test too |
…tentry/litentry-parachain into p-1275-omni-bridge-precompile
|
Still confirming ts-test, let me merge manually later. |
|
Yes, it is caused by failed to decode event data. ready to merge. TODO fix in future. |
omni bridge precompile