Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding email identity to core primitives #3063

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

silva-fj
Copy link
Contributor

This PR updates the Identity primitive type by adding Email variant.

@silva-fj silva-fj requested a review from a team September 11, 2024 16:20
Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillyWooo BillyWooo merged commit 1382d59 into release-v0.9.19 Sep 12, 2024
4 of 17 checks passed
@BillyWooo BillyWooo deleted the add-email-identity-to-core-primitives branch September 12, 2024 04:25
jonalvarezz added a commit that referenced this pull request Sep 23, 2024
* feat: P-1006 add new Assertion enum item LinkedIdentities (#3042) (#3051)

Co-authored-by: higherordertech <higherordertech>

* adding email identity to core primitives (#3063)

* adding email identity to core primitives

* fixing formatting issue

* Handling missing enum branches in match patterns (#3064)

Handling missing variants for LinkedIdentities and Identity in match patterns

* re-apply changes from #3064 after restructure

Signed-off-by: Jonathan Alvarez <[email protected]>

---------

Signed-off-by: Jonathan Alvarez <[email protected]>
Co-authored-by: will.li <[email protected]>
Co-authored-by: Francisco Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants