Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up STF request_vc call #3050

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Clean up STF request_vc call #3050

merged 9 commits into from
Sep 9, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic.

We only use author_requestVc to send vc request, so both STF rust and ts part are removed.

It includes a bunch of clippy warning fixes too.

@Kailai-Wang Kailai-Wang self-assigned this Sep 6, 2024
Copy link

linear bot commented Sep 6, 2024

Copy link
Contributor

@jonalvarezz jonalvarezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that we will no longer able to use Polkadot.js App to request VCs, right?

However, since we are working on these series of playground tools, that part should be covered. so, nothing against merging.

@Kailai-Wang
Copy link
Collaborator Author

Yes it was discussed before - we have your sandbox :)

Copy link
Member

@felixfaisal felixfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kailai-Wang Kailai-Wang merged commit 804ab80 into dev Sep 9, 2024
27 checks passed
@Kailai-Wang Kailai-Wang deleted the p-963-cleanup-stf-vc-call branch September 9, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants