add missing dcap arg within dockerfile #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyWooo
force-pushed
the
enable_dcap_feature
branch
from
e91108e to
15568b3
Compare
|
Shall we use DCAP in regular CI too? |
Co-authored-by: higherordertech <higherordertech>
Maybe not. Because it requires hardware. Regular CI runners don't have hardware. |
|
I think we should let it run with DCAP RA - you could double-check how these RA extrinsics are generated. It's a skip-ra variant, but it's a dcap version of skip-ra |
Not really, this PR doesn't change any logic within ci.yml. So our general CI is not affected. DCAP feature will only be enabled when building release package. |
Kailai-Wang
approved these changes
Aug 27, 2024
BillyWooo
added a commit
that referenced
this pull request
Aug 27, 2024
* add missing arg within dockerfile * copy missing protobuf * fix: use dynamic date for unit test (#3015) Co-authored-by: higherordertech <higherordertech> * add dcap as default feature --------- Co-authored-by: will.li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no RA_METHOD args within dockerfile. So the parameter from yml file is not passed into dockerfile when building release docker images.
Ref:
https://github.com/litentry/litentry-parachain/blob/f138676e152adb07fc1dc02572e1cae2d482ed51/.github/workflows/create-release-draft.yml#L219
https://github.com/litentry/litentry-parachain/blob/f138676e152adb07fc1dc02572e1cae2d482ed51/.github/workflows/create-release-draft.yml#L292