Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity staking follow up #2976
Identity staking follow up #2976
Changes from 63 commits
edec591
addc61f
5a12d7b
f81d31b
3ff0778
15a0d0c
7da34b3
a3ed38d
a7a9541
2c92a8b
7d6ec85
9ebaa37
551c144
07a4d9d
1ae43f9
554574d
e1c2b06
54cdfd1
44213e6
a9d6518
4e17619
f63032c
72160ab
58c7936
fe012ec
bc80b26
1bcaf5e
169582d
da41659
7366a47
02d90f5
fe15047
a4465dc
631b988
cd1ea06
375f7e9
448768e
5c2dc8f
f440a5b
c041244
d36294e
ad3c7c7
8e3e0e1
2dde232
844dbd0
51392f6
0dbb5d6
a6ff29e
ec23008
8393226
e4d4d30
a3a6ca3
717394f
aa3a50e
a4bed37
d6e1dc7
cd372d5
c024590
53e9064
a4b07e3
f629e0c
d4e78de
cee2e50
0aaab16
682ce17
04fc8e0
a256862
3de1822
a52c90d
af81e38
8e375f0
2db3da4
02ce832
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm strange - where is the token distribution process? (I thought it would be done within this extrinsic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just to trigger an event that marks the distribution for the round as completed. (Currently we don't do anything with the
token_staking_amount
, will there be another phase/issue to come?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean "distribution for the round as completed" should be triggered by the worker - when it finishes with staking amount upload for all accounts, it should trigger the distribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code to make the distribution on
update_token_staking_amount
, this extrinsic will be kept to signal that the distribution for the round is completed.