-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p-836 Update vc correctness #2969
Conversation
72390fe
to
dd9020d
Compare
TBH this only verifies each DP's validity, but not the VC logic. We simply have:
That's it I guess that's too much for this PR alone tho |
env: | ||
GITHUB_EVENT_NAME: ${{ github.event_name }} | ||
DOCKER_TAG: ${{ github.event.inputs.docker-tag }} || latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the env
in the workflow level
ef4509b
to
976f4a4
Compare
Context
this pr:
All addresses have been tested locally and can pass.
There may still be some missing VC tests, we can add and update at any time. Let this workflow run first.