Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-836 Update vc correctness #2969

Merged
merged 24 commits into from
Sep 1, 2024
Merged

Conversation

0xverin
Copy link
Contributor

@0xverin 0xverin commented Aug 7, 2024

Context

this pr:

  • Set gha as a scheduled task.
  • Updated identity-linking addresses.
  • Optimized the testing process

All addresses have been tested locally and can pass.
There may still be some missing VC tests, we can add and update at any time. Let this workflow run first.

Copy link

linear bot commented Aug 7, 2024

@0xverin 0xverin marked this pull request as draft August 7, 2024 13:12
@0xverin 0xverin changed the title [WIP]p-836 Fix vc correctness [WIP]p-836 Update vc correctness Aug 8, 2024
@0xverin 0xverin marked this pull request as ready for review August 21, 2024 02:55
@0xverin 0xverin changed the title [WIP]p-836 Update vc correctness p-836 Update vc correctness Aug 21, 2024
@0xverin 0xverin requested review from Kailai-Wang and a team August 21, 2024 02:57
@0xverin 0xverin force-pushed the fix-vc-correctness-verification-gha branch from 72390fe to dd9020d Compare August 22, 2024 14:25
@Kailai-Wang
Copy link
Collaborator

TBH this only verifies each DP's validity, but not the VC logic.
E.g. our LIT holding amount VC consults multiple DPs and sums them (or quits early) -> what if DP works OK but our logic goes wrong?
So the testing unit should be VC, not DP...

We simply have:

  • predefined IDGraph
  • VC-type
  • If the generated VC meets the expected result

That's it

I guess that's too much for this PR alone tho

Comment on lines 20 to 22
env:
GITHUB_EVENT_NAME: ${{ github.event_name }}
DOCKER_TAG: ${{ github.event.inputs.docker-tag }} || latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the env in the workflow level

@0xverin 0xverin force-pushed the fix-vc-correctness-verification-gha branch from ef4509b to 976f4a4 Compare August 27, 2024 06:42
@Kailai-Wang Kailai-Wang enabled auto-merge (squash) September 1, 2024 15:15
@Kailai-Wang Kailai-Wang merged commit 76e1bb4 into dev Sep 1, 2024
34 checks passed
@Kailai-Wang Kailai-Wang deleted the fix-vc-correctness-verification-gha branch September 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants