Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint support #29

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Conversation

dreamz12345
Copy link

Hello,
I added Hint support and tests. I also fixed a linter warning. The code seems to go through github actions.

@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12729342108

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.611%

Totals Coverage Status
Change from base Build 10686588893: 0.002%
Covered Lines: 768
Relevant Lines: 771

💛 - Coveralls

Copy link
Owner

@liran-funaro liran-funaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks good.
Please fix this minor issue and I'll merge your PR.

sphinx_markdown_builder/contexts.py Outdated Show resolved Hide resolved
@liran-funaro liran-funaro merged commit 1442857 into liran-funaro:main Jan 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants