This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Prevent duplicate IDs on order/refund save #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the WPDB class doesn't have anything like insertOrUpdate(), this tiny query takes an order ID and tells us whether or not there's an entry in the custom orders table for that ID (since each order/refund) has exactly one row.
…om orders table There's a not-so-great convention of `$this->creating` from earlier in development, but this value can be deceiving. Until we're able to refactor it out, verify that any requests for inserting rows into the custom orders table check that a row doesn't already exist.
… property Instead of trusting a property that isn't always accurate, explicitly see if a row exists before trying to insert.
As of a few minutes ago, the WordPress build tools should be fixed, enabling us to continue our tests against trunk. Reference: https://core.trac.wordpress.org/ticket/43055
…ata_Store_Custom_Table.
bswatson
approved these changes
May 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a few different occasions (#49, #47, #58), users have reported errors similar to:
These errors were the result of
WC_Order_Data_Store_Custom_Table::$creatingnot always being set properly, so the plugin would sometimes try toINSERTrather thanUPDATEthe corresponding database row.Additionally, since the
WC_Order_Refund_Data_Store_Custom_Tablefrom #52 — which this PR depends upon — was largely copied fromWC_Order_Data_Store_Custom_Table(I really can't wait until we can use PHP traits in WordPress!), that class would have run into the same issue.This PR simplifies the logic around the data stores'
update_post_meta()methods, explicitly checking whether or not a corresponding database row exists and, if not, explicitly inserting it. This enables us to remove the less-than-ideal$creatingproperties and avoid duplicate IDs.Blocked by #52. Fixes #47, fixes #49.