This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve a few issues that have come up in testing, with the hopes of making the test suite less fragile as WooCommerce evolves:
1. Return to using the official WooCommerce upstream
A number of our PRs have been merged into WooCommerce core, so there's no longer a need for our temporary
feature/more-orders-tests
branch.2. Simplify the bootstrap file
Since the Custom Orders Table plugin relies on WooCommerce, let the WooCommerce core test suite bootstrap everything before we activate. This prevents incidents where, for example, a test run in isolation did not have access to the custom table.
3. Fix an improperly-nested else statement in WC_Order_Data_Store_Custom_Table::filter_database_queries()
This
else
statement was one level too high, causing issues when order queries were constructed with bothcustomer_emails
andcustomer_ids
meta queries. Additional tests have been added around the method to prevent regressions.4. Bump all Composer dependencies
We're only as good as the latest version of WooCommerce we're testing against.
Please note that there is one failing test, which is to be expected; the results of
WC_Install::get_tables()
are not sorted, so the order of the tables comes out jumbled:I'm working on fixing this within WooCommerce core in woocommerce/woocommerce#20045.