Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vagrantfile to forward vm port to access grpc api & fix validations #170

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

jmickey
Copy link
Contributor

@jmickey jmickey commented Oct 26, 2021

What this PR does / why we need it:

This PR achieves 2 things:

  1. Updates the Vagrantfile to forward port 9090 from the guest VM to the host. This allows you to connect to the gRPC server from BloomRPC running on the host machine. NOTE: You need to run flintlockd with the --grpc-endpoint=0.0.0.0:9090 flag, otherwise the connection is rejected.
  2. Fixes some incorrect validations. GuestMAC is optional, and the file validation is rubbish.

Checklist:

  • squashed commits into logical changes

@jmickey jmickey added the kind/bug Something isn't working label Oct 26, 2021
yitsushi
yitsushi previously approved these changes Oct 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #170 (94ab549) into main (12b503c) will increase coverage by 6.90%.
The diff coverage is 56.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   40.09%   47.00%   +6.90%     
==========================================
  Files          32       45      +13     
  Lines        1444     1951     +507     
==========================================
+ Hits          579      917     +338     
- Misses        789      930     +141     
- Partials       76      104      +28     
Impacted Files Coverage Δ
core/application/app.go 100.00% <ø> (ø)
core/application/errors.go 0.00% <0.00%> (ø)
core/application/query.go 0.00% <ø> (ø)
core/application/reconcile.go 0.00% <0.00%> (ø)
core/models/volumes.go 0.00% <ø> (ø)
core/plans/microvm_update.go 0.00% <0.00%> (ø)
core/steps/runtime/dir_create.go 42.30% <ø> (ø)
core/steps/runtime/initrd_mount.go 0.00% <ø> (ø)
core/steps/runtime/kernel_mount.go 0.00% <ø> (ø)
core/steps/runtime/volume_mount.go 0.00% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50efcf...94ab549. Read the comment docs.

@Callisto13
Copy link
Member

Fixes some incorrect validations. GuestMAC is optional, and the file validation is rubbish.

aha! these are the things that were yelling at me 🙇‍♀️

@Callisto13
Copy link
Member

NOTE: You need to run flintlockd with the --grpc-endpoint=0.0.0.0:9090 flag, otherwise the connection is rejected.

is this bit in the docs?

@jmickey
Copy link
Contributor Author

jmickey commented Oct 26, 2021

is this bit in the docs?

@Callisto13 - wasn't sure the best place to put it to be honest. Maybe the quick-start?

@jmickey jmickey merged commit fc1e131 into main Oct 26, 2021
@jmickey jmickey deleted the chore/forward-port branch October 26, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants